[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: CRAM-MD5 for POP3 patch - please review



* Russell Nelson <nelson@xxxxxxxxxx> [2004-03-01 21:37]:
> Alex Pleiner writes:
>  > Could you please have a look at the code and direct me to problems or
>  > bugs within. Your help is appreciated very much.

> It looks reasonable, but isn't a full patch.  It doesn't change the
> makefile, nor does it provide base64.[ch].

Thanks for your answer. You are right. The patch is not usable by
itself. I should have noted that. 

As the changes to Makefile are trivial and base64.[ch] are provided by
the smtp_auth-patch, I left them aside when asking for your advice.

After I have thoroughly tested the patch and did not receive comments on
problems I will publish a full patch including the missing files and
some documentation.

Alex

-- 
Alex Pleiner
zeitform Internet Dienste         Fraunhoferstrasse 5
                                  64283 Darmstadt, Germany
http://www.zeitform.de            Tel.: +49 (0)6151 155-635
mailto:pleiner@xxxxxxxxxxx        Fax:  +49 (0)6151 155-634
GnuPG/PGP Key-ID: 0x613C21EA